Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Replace requirements-min.txt with other testing method #1234

Open
rly opened this issue Jan 17, 2025 · 0 comments
Open

[Feature]: Replace requirements-min.txt with other testing method #1234

rly opened this issue Jan 17, 2025 · 0 comments
Assignees
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: testing issues related to testing
Milestone

Comments

@rly
Copy link
Contributor

rly commented Jan 17, 2025

What would you like to see added to HDMF?

In at least 4 separate cases, external developers have confused requirements-min.txt (or requirements.txt which has since been removed) as the pinned requirements used by the package, when in fact, it is used only for reproducible testing of minimum requirements.

Although pip does not yet include a way to specify installing a package with its minimum (lower bound) version of dependencies (ref: pypa/pip#8085), other package dependency resolvers such as uv and pdm support this.

What solution would you like?

uv pip install . --resolution lowest-direct: https://docs.astral.sh/uv/concepts/resolution/#resolution-strategy

For minimum version testing, we may want to use this and get rid of the confusing requirements-min.txt file.

Alternatively, we could write a little script that extracts the minimum versions of dependencies and installs those.

Do you have any interest in helping implement the feature?

Yes.

@rly rly added category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: testing issues related to testing labels Jan 17, 2025
@rly rly added this to the Future milestone Jan 17, 2025
@rly rly self-assigned this Jan 17, 2025
@rly rly changed the title [Feature]: requirements-min.txt is confusing [Feature]: Replace requirements-min.txt with other testing method Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: testing issues related to testing
Projects
None yet
Development

No branches or pull requests

1 participant