Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Inconsistent config prefixes for health-related settings #9322

Closed
tjquinno opened this issue Oct 3, 2024 · 0 comments · Fixed by #9337
Closed

3.x Inconsistent config prefixes for health-related settings #9322

tjquinno opened this issue Oct 3, 2024 · 0 comments · Fixed by #9337
Assignees
Labels
3.x Issues for 3.x version branch health P3

Comments

@tjquinno
Copy link
Member

tjquinno commented Oct 3, 2024

Environment Details

  • Helidon Version: 3.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

The config keys for health-related settings mostly start with health. but for the built-in health checks which themselves are configurable those keys start with helidon.health. (such as helidon.health.diskSpace.thresholdPercent for example).

With the fix in place for #8617 the doc and the code now agree for all the settings, but the inconsistency among the config keys is awkward and confusing.

The settings which start with helidon.health. should be just health. instead. But we'll need to maintain backward compatibility
so we probably need to support both prefix styles for the settings that currently start with helidon.health.. There's an existing utility class that handles deprecated config keys including logging warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch health P3
Projects
Archived in project
2 participants