Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

broken cursor on /cities/:id/hotspots endpoint #415

Open
allenan opened this issue Mar 8, 2022 · 5 comments
Open

broken cursor on /cities/:id/hotspots endpoint #415

allenan opened this issue Mar 8, 2022 · 5 comments
Assignees

Comments

@allenan
Copy link
Member

allenan commented Mar 8, 2022

following the cursor on https://api.helium.io/v1/cities/bmV3IHlvcmtuZXcgeW9ya3VuaXRlZCBzdGF0ZXM/hotspots (New York) for example results in a "not found" error

@mortonmj
Copy link

mortonmj commented Mar 9, 2022

I believe this is the issue in the source:

File: /blockchain-http/src/bh_route_cities.erl

Line 20: -define(S_CITY_HOTSPOT_LIST_BEFORE, "hotspor_city_list_before").

The fix is to correct the misspelling of hotspor to hotspot. ;-)

Cheers

@madninja
Copy link
Member

madninja commented Mar 9, 2022

I believe this is the issue in the source:

File: /blockchain-http/src/bh_route_cities.erl

Line 20: -define(S_CITY_HOTSPOT_LIST_BEFORE, "hotspor_city_list_before").

The fix is to correct the misspelling of hotspor to hotspot. ;-)

Good typo catch. I don't believe that's he issue since that is only the identifier used in the query cache. Did you confirm that it actually fixes the issue here?

@mortonmj
Copy link

mortonmj commented Mar 9, 2022

I wish I had the setup to do so. I have not confirmed this would fix the issue. Apologies if this misled. Just wanted to report this observation and coincidence.

@madninja
Copy link
Member

madninja commented Mar 9, 2022

Not a coincidence but a sharp eye for spelling mistakes.. May be worth stating it as a separate bug next time or at least not make it sounds like "the fix"

@mortonmj
Copy link

mortonmj commented Mar 9, 2022

Agree.
Thanks for investigating.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants