Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info in Chat message from promoting, demoting, kicking, accepting, declining #840

Open
yoyopuyo opened this issue Apr 26, 2022 · 0 comments

Comments

@yoyopuyo
Copy link

Hello,

small improvement proposition for chat messages coming from promoting, demoting, kicking, accepting, declining requests

Here is what I get from promoting
ChannelId: 3.33983b27-f50c-40f8-bda5-d7af094b371e.., Code: 7,
Content: {}, CreateTime: 2022-04-25T18:02:45Z, GroupId: 33983b27-f50c-40f8-bda5-d7af094b371e, MessageId: 6ae1ddf8-faab-4c40-ab09-d936a2eefa51, Persistent: True, RoomName: , SenderId: 15f35ef1-0833-4c8a-87e4-f06c7064d8e9, UpdateTime: 2022-04-25T18:02:45Z, UserIdOne: , UserIdTwo: , Username: MkPJEJoGfU,

So I get the id of the player that has been promoted and his Username. (senderId and UserName)

What I'd like to show in the chat is this:
"PlayerName1 was promoted by PlayerName2".
This is a very typical way of showing it (Clash Royale uses this format for example)

I got the SenderId so I could find his name but I'd have to call the server for this. It would be nice if SenderDisplayName was provided in the message.
Same thing for the player that did the action. I don't have either the id or display name in the message.

In the mean time, I'll attach an after-hook to these operations and send a chat message to the group.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant