install.sh script has escaping error

[dan-massey]

This project is for the Heroku CLI only and issues are reviewed as we are able. If you need more immediate assistance or help with anything not specific to the CLI itself, please use https://help.heroku.com.

Do you want to request a feature or report a bug?

Bug
What is the current behavior?

On an Oracle Linux machine, running the install bash script (curl https://cli-assets.heroku.com/install.sh | sh) would show the error "Your path is missing /usr/local/bin, you need to add this to use this installer." even if /usr/local/bin was available in the current PATH.

What is the expected behavior?

The install bash script should succeed.

I believe this can be achieved by changing the escaping in the if condition

if [[ ! ":$PATH:" == *":/usr/local/bin:"* ]]; then

(instead of if [[ ! ":\$PATH:" == *":/usr/local/bin:"* ]];)

[justinwilaby]

HI @dan-massey - It does seem like your suggestion will work. If I'm not mistaken, the existing codeif [[ ! ":\$PATH:" == *":/usr/local/bin:"* ]]; then could match on paths like /usr/local/bin64 or usr/local/bin.old, as well potentially leading to other defects.

Are you able to install successfully after making this change locally?

[dan-massey]

Yes, I made the change in a local copy of the script and successfully installed the CLI.

I'm happy to open a PR if it would be helpful/accepted.

[justinwilaby]

@dan-massey - By all means. Please open a PR. we love our contributors!

[justinwilaby]

W-17567855 created