Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Msvc fixes #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Msvc fixes #8

wants to merge 1 commit into from

Conversation

RonaldZielaznicki
Copy link
Contributor

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Wish I could compare this to my previous PR. Then you'd only see the relevant commits.

@slimsag
Copy link
Member

slimsag commented Oct 16, 2024

@RonaldZielaznicki now that #7 is merged, can you git rebase -i origin/main this branch?

@RonaldZielaznicki
Copy link
Contributor Author

@slimsag Yeah, I can do that.

@RonaldZielaznicki
Copy link
Contributor Author

Just to clarify, this is a partial fix.

It does not get MSVC builds work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonaldZielaznicki @slimsag