Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma panel overrides all panels #6

Open
cjol opened this issue Nov 1, 2018 · 7 comments
Open

Figma panel overrides all panels #6

cjol opened this issue Nov 1, 2018 · 7 comments

Comments

@cjol
Copy link

cjol commented Nov 1, 2018

I can't combine this with other decorators... Am I doing something wrong?

storiesOf("Button", module)
  .addDecorator(
    figmaDecorator({
      url:
        "https://www.figma.com/file/OWJzZno8PNd5bABas6y3uxxP/Untitled?node-id=1%3A6694"
    })
  )
  .addDecorator(withKnobs)
  .addDecorator(withNotes)
  .add(
    "with text",
    () => (
      <Button
        onClick={action("button clicked")}
        disabled={boolean("Disabled", false)}
      >
        {text("Label", "Click me!")}
      </Button>
    ),
    { notes: { markdown: "# Button\n\n >Does some *cool* stuff!" } }
  )

But the Notes, Knobs and Viewports panels all just show the same figma file:
image

@fullflavedave
Copy link

I'm also seeing this problem.

@dlombardi
Copy link

Seeing this as well. I will probably uninstall until this is resolved.

@darrencrossley
Copy link

I'm was also experiencing this - and it was really annoying.

simple solution for now was to make sure it was the last entry in addons.js:

import '@storybook/addon-knobs/register';
import '@storybook/addon-actions/register';
import 'storybook-addon-figma/register';
<EOF>

@gavinkilbride
Copy link

gavinkilbride commented Jun 13, 2019

This is still happening and the solution from darrencrossley didn't work for me, so I created a manager-head.html file in my storybook folder and added the following:

<style>
#storybook-panel-root>div:nth-child(2) > div {
  background: white;
}
</style>

It just sets the background color of the tab pages to white so they don't 'leak through'.

@shubjhamb
Copy link

Same happening with me, and order fix didn't work for me

@vojvodics
Copy link

vojvodics commented Dec 12, 2019

I fixed it on my fork (not planning to submit PR since the package is not being maintained)

I also needed vue support, so I forked from #4 and fixed this issue from there.

If you need it you can install it from my fork (https://github.com/vojvodics/storybook-addon-figma/releases/tag/0.1.1) npm i https://github.com/vojvodics/storybook-addon-figma.git\#0.1.1 -D

@KevinVandy
Copy link

@hharnisc is it possible that we could get an official update to fix this issue where the figma tab is always showing on every other addon tab? We would love to just be able to install from the official source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants