Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'org.hiero.gradle.check.gradle-properties' convention plugin #7

Open
jjohannes opened this issue Nov 14, 2024 · 2 comments
Open
Assignees
Milestone

Comments

@jjohannes
Copy link
Contributor

The gradle.properties file needs to be used to configure global switches directly in each repository. This can not be moved into these plugins, but the plugins may check if the build is configured as expected and otherwise emit a warning:

# Build Cache turned on?
org.gradle.configuration-cache=true

# Configuration Cache turned on?
org.gradle.caching=true

# JVM args contain '-Dfile.encoding=UTF-8'
org.gradle.jvmargs=-Dfile.encoding=UTF-8 ...
@jjohannes
Copy link
Contributor Author

Also check that a minimal Gradle version of the plugins is met. If not, projects need to update Gradle together with the plugins.

Initially this will be Gradle 8.11.1.

@jjohannes
Copy link
Contributor Author

Failing for the wrong minimal Gradle version will also allow us to indirectly use Dependabot to update Gradle regularly in the other repos. When we release a new version of these plugins for a new Gradle version, Dependabot will create a PR for updating org.hiero.gradle.build. Then the PR CI build will fail, telling to update Gradle as well as part of the PR.

@jjohannes jjohannes self-assigned this Dec 18, 2024
@jjohannes jjohannes added this to the v0.2.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant