Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new error type and exit when needed #487

Merged

Conversation

georgi-l95
Copy link
Member

Description:
This PR adds UnresolvableError type, when something like docker is not running or is wrong version occurred.

Related issue(s):

Fixes #486

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@georgi-l95 georgi-l95 linked an issue Jan 8, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@georgi-l95 georgi-l95 requested a review from isavov January 8, 2024 09:16
@georgi-l95 georgi-l95 self-assigned this Jan 8, 2024
Copy link
Contributor

@isavov isavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ 👍 👨‍💻

@georgi-l95 georgi-l95 merged commit fbe7e14 into main Jan 8, 2024
8 checks passed
@georgi-l95 georgi-l95 deleted the 486-local-node-is-not-exiting-when-docker-is-not-started branch January 8, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local node is not exiting when docker is not started
2 participants