Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Creates a docker resources check #488

Merged
merged 8 commits into from
Jan 18, 2024
Merged

feat: Creates a docker resources check #488

merged 8 commits into from
Jan 18, 2024

Conversation

konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented Jan 8, 2024 •
edited
Loading

Description:

This PR adds a docker resources check in the docker service and adds it to the InitState
Related issue(s):

Fixes #437

@konstantinabl konstantinabl linked an issue Jan 8, 2024 that may be closed by this pull request
Add Resource check before startup #437
Closed
@konstantinabl konstantinabl changed the title Creates a docker resources check feat: Creates a docker resources check Jan 8, 2024
georgi-l95
georgi-l95 reviewed Jan 8, 2024
View reviewed changes
@konstantinabl konstantinabl force-pushed the 437-add-resource-check-before-startup branch from f3a30f1 to ca9b715 Compare January 8, 2024 12:43
@konstantinabl konstantinabl marked this pull request as draft January 8, 2024 13:51
@konstantinabl konstantinabl marked this pull request as ready for review January 8, 2024 14:44
georgi-l95
georgi-l95 reviewed Jan 9, 2024
View reviewed changes
@konstantinabl
Drafts docker resources check
ba090dc 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
Refactors method and improves resource checks
4e52024 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
Simplify process.env check
fd967b3 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
Moves constants to constants file
1d12872 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
Adds constants to error messages
d5ca695 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
Removes process exit and exits through observer
a79e289 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl
Fixes handleMemoryError method
5fabc67 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl force-pushed the 437-add-resource-check-before-startup branch from 7b9c092 to 5fabc67 Compare January 17, 2024 14:06
isavov
isavov suggested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@isavov isavov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Sonar gate

@konstantinabl
Improces check memory resources logic
c589e23 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konstantinabl konstantinabl merged commit 8876ae2 into main Jan 18, 2024
11 checks passed
@konstantinabl konstantinabl deleted the 437-add-resource-check-before-startup branch January 18, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgi-l95 georgi-l95 georgi-l95 approved these changes

@isavov isavov isavov approved these changes

@stefan-stefanooov stefan-stefanooov Awaiting requested review from stefan-stefanooov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Resource check before startup
4 participants
@konstantinabl @stefan-stefanooov @georgi-l95 @isavov