Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityIdUtils ignores realm and shard #10412

Open
steven-sheehy opened this issue Feb 17, 2025 · 0 comments
Open

EntityIdUtils ignores realm and shard #10412

steven-sheehy opened this issue Feb 17, 2025 · 0 comments
Assignees
Labels
enhancement Type: New feature web3 Area: Web3 API

Comments

@steven-sheehy
Copy link
Contributor

steven-sheehy commented Feb 17, 2025

Problem

The web3 module incorrectly uses just long entity num in places instead of using shard, realm and num.

Solution

  • Change any method in EntityIdUtils to use shard and realm when encoding from an object to/from bytes or numerics
  • Remove BitPackUtils
  • Change EntityNum to internally use EntityId
  • Investigate other areas like AllowanceId

Alternatives

No response

@steven-sheehy steven-sheehy added enhancement Type: New feature web3 Area: Web3 API labels Feb 17, 2025
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node (Archived) Feb 17, 2025
@rbarker-dev rbarker-dev moved this to 🏃‍♀ Sprint backlog in Mirror Node Feb 20, 2025
@jnels124 jnels124 self-assigned this Feb 26, 2025
@jnels124 jnels124 moved this from 🏃‍♀ Sprint backlog to 👷 In progress in Mirror Node Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
Status: 👷 In progress
Development

No branches or pull requests

2 participants