Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contract storage readable kv state slot values #10480

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix contract storage readable kv state slot values #10480

merged 2 commits into from
Feb 25, 2025

Conversation

kselveliev
Copy link
Contributor

Description:
This PR fixes slot values in ContractStorageReadableKVState and expand the slot values to 32 bytes.

Partially completes #10430

Notes for reviewer:

Tests that this pr fixes

Then I call function with update and I expect return of the updated value
Then I call function that makes N times state update

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@kselveliev kselveliev added enhancement Type: New feature web3 Area: Web3 API modularizedEVM labels Feb 24, 2025
@kselveliev kselveliev self-assigned this Feb 24, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...state/keyvalue/ContractStorageReadableKVState.java 100.00% <ø> (ø) 5.00 <0.00> (ø)

... and 994 files with indirect coverage changes

@kselveliev
fix: Addressing review comments
96f17d3 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@kselveliev kselveliev marked this pull request as ready for review February 25, 2025 08:58
@kselveliev kselveliev requested a review from a team as a code owner February 25, 2025 08:58
bilyana-gospodinova
bilyana-gospodinova approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy added this to the 0.125.0 milestone Feb 25, 2025
@steven-sheehy steven-sheehy merged commit b7f560a into main Feb 25, 2025
31 of 32 checks passed
@steven-sheehy steven-sheehy deleted the 10430-fix-contract-storage-slot-values branch February 25, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@bilyana-gospodinova bilyana-gospodinova bilyana-gospodinova approved these changes

@filev94 filev94 filev94 approved these changes

@sdimitrov9 sdimitrov9 Awaiting requested review from sdimitrov9

Assignees

@kselveliev kselveliev

Labels
enhancement Type: New feature modularizedEVM web3 Area: Web3 API
Projects
None yet
Milestone
0.125.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kselveliev @steven-sheehy @bilyana-gospodinova @filev94