Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Support GitLab #48

Open
TheCodeDestroyer opened this issue Feb 24, 2016 · 6 comments
Open

Support GitLab #48

TheCodeDestroyer opened this issue Feb 24, 2016 · 6 comments

Comments

@TheCodeDestroyer
Copy link

Just a question(type), I see that most of the code refers to GitHub,
but I was wondering if you are thinking of maybe supporting GitLab as well?

P.S.: The only decent NodeJS Gitlab API wrapper I found is this one, but doesn't support labels from what I can see...

@himynameisdave
Copy link
Owner

Short answer: yes, eventually...

It was kindly pointed out to me on Reddit that naming this project git-labelmaker when it actually only applies to GitHub was kind of a goof. So as a result I feel like in the future we should support GitLab and BitBucket, or maybe just rename this tool github-labelmaker and create a separate tool for GitLab.

Now in terms of a timeframe, I'm not going to lie there are other features we would like to add here first.

Thanks for your question!

@Jameskmonger
Copy link
Collaborator

I initially added this to the 0.9.0 milestone, but I haven't used GitLab before. I'd like to take a bit more of a look into their API.

@himynameisdave
Copy link
Owner

Yeah this isn't a priority for 0.9.0, I'm thinking this is a significant change that would be better for a 1.x release

@TheCodeDestroyer
Copy link
Author

TheCodeDestroyer commented Feb 25, 2016

Since your code tightly couples to GitHub API, maybe it wouldn't be a bad idea to rename this to "github-labelmaker" and make the other two as separate projects. You probably don't want to get into the battle where one change breaks the other two and vice-versa.

@Jameskmonger
Copy link
Collaborator

I think we could potentially have this as a project which supports labelling for the different platforms, we can just let the user select which service they want to use.

@himynameisdave himynameisdave added this to the v1.x milestone Apr 2, 2017
@dxlr8r
Copy link

dxlr8r commented Feb 13, 2018

Would love gitlab support as well :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants