Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The moved piece outline is hard to spot in the dark theme #217

Open
neongreen opened this issue May 15, 2024 · 9 comments
Open

The moved piece outline is hard to spot in the dark theme #217

neongreen opened this issue May 15, 2024 · 9 comments

Comments

@neongreen
Copy link

image image
@klautcomputing
Copy link
Collaborator

@neongreen I agree, do you have a preferred way of fixing it?

@neongreen
Copy link
Author

Not really tbh

@klautcomputing
Copy link
Collaborator

We could pick a different color or make the outline a bit bigger. I am gonna ask on the discord for some ideas.

@klautcomputing
Copy link
Collaborator

It works well for you in the light scheme though?

@neongreen
Copy link
Author

I don’t play with the light theme so I can’t really tell for sure. But yeah I think it’s much more noticeable

@IongIer
Copy link
Collaborator

IongIer commented May 19, 2024

Maybe a neongreen for darkmode? 😸

@IongIer
Copy link
Collaborator

IongIer commented May 19, 2024

Selection_001
Selection_002
To me it seems like neongreen works for black pieces in darkmode but not so much for the white piece.
The pink in lightmode contrasts better with the white pieces compared to the black ones.

@neongreen
Copy link
Author

My comments on whether the above helps or not:

image

@neongreen
Copy link
Author

neongreen commented Jun 6, 2024

I played around in Pixelmator and here is my attempt to come up with outlines that would work for both dark and light pieces:

image image

I can't say I love them, but they seem to be easier to spot.

I have an SVG export but honestly idk if it's editable easily / at all. Anyway, outlines.svg here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants