Skip to content
This repository has been archived by the owner on Jan 28, 2023. It is now read-only.

Please register SimpleDataFrame for polymorphic serialization in the future if possible. #131

Open
arybach opened this issue Nov 1, 2021 · 3 comments
Assignees

Comments

@arybach
Copy link

arybach commented Nov 1, 2021

Exception in thread "main" kotlinx.serialization.SerializationException: Class 'SimpleDataFrame' is not registered for polymorphic serialization in the scope of 'DataFrame'.
Mark the base class as 'sealed' or register the serializer explicitly.

Thank you very much.

@holgerbrandl
Copy link
Owner

What about GroupedDataFrame? Wouldn't we then rather need to mark the upstream interface DataFrame itself?

I've tried but did not come up with a good argument against sealed. So this should work.

@arybach
Copy link
Author

arybach commented Nov 2, 2021

Great! Thx vm.

@arybach arybach closed this as completed Nov 2, 2021
@holgerbrandl holgerbrandl reopened this Nov 2, 2021
@holgerbrandl
Copy link
Owner

Let's keep it open until it is actually implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants