New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output file name for mariabackup and xtrabackup providers #372

Open

mikegriffin opened this issue Mar 19, 2024 · 0 comments

Contributor

mikegriffin commented Mar 19, 2024 •

edited

Loading

Both versions appear to force stream format to mbstream or xbstream (tar no longer supported):

    else:
        args.append("--backup")
        if stream:
            args.append("--stream=xbstream")

Holland then keeps the originally configured stream method, ie tar by default, in the filename:

     if stream:
            if stream == "tar":
                archive_path = join(backup_directory, "backup.tar")
            elif stream == "xbstream":
                archive_path = join(backup_directory, "backup.xb")

It would be good for the mk-config command to not default to tar, and to change the output file name away from tar.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment