Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting xaxis/yaxis as string #1442

Open
ahuang11 opened this issue Oct 15, 2024 · 3 comments · May be fixed by #1497
Open

Allow setting xaxis/yaxis as string #1442

ahuang11 opened this issue Oct 15, 2024 · 3 comments · May be fixed by #1497
Labels
type: bug Something isn't working
Milestone
v0.11.3

Comments

@ahuang11
Copy link
Collaborator

Like xaxis="top" "bottom" etc
https://holoviews.org/user_guide/Customizing_Plots.html#axis-positions
@maximlt
Copy link
Member

maximlt commented Jan 27, 2025

Would it also be OK for you to use an enum like hvplot.AXIS_LOC.Top (naming can be improved)?

@maximlt maximlt added type: enhancement New feature or request and removed TRIAGE labels Jan 27, 2025
@ahuang11
Copy link
Collaborator Author

ahuang11 commented Feb 7, 2025 •
edited
Loading

Yeah I'm fine with that, as long it supports both (i.e. "top" and hvplot.AXIS_LOC.Top)--the enum will simply check if the string is valid and cast as necessary.

If enums are a thing, I think they should be implemented in HoloViews, and hvPlot imports it.

@maximlt maximlt added type: bug Something isn't working and removed type: enhancement New feature or request labels Feb 13, 2025
@maximlt maximlt linked a pull request Feb 13, 2025 that will close this issue
Open
@maximlt
Copy link
Member

maximlt commented Feb 13, 2025

@ahuang11 I think this was just a bug, MR to fix it #1497.

As for the enums, I'm not sure why I suggested it exactly now, I was probably using a library that offered options this way and thought it was a great user experience. I agree that should be implemented in HoloViews first.

@maximlt maximlt added this to the v0.11.3 milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.11.3
Development

Successfully merging a pull request may close this issue.

Fix setting xaxis/yaxis holoviz/hvplot
2 participants
@ahuang11 @maximlt