Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking of _PYVIZ_COMMS_INSTALLED environment variable in our system #131

Open
nishikantparmariam opened this issue Jan 21, 2025 · 1 comment

Comments

@nishikantparmariam
Copy link

ALL software version info

Software Version Info
pyviz_comms==3.0.4

Description of expected behavior and the observed behavior

After upgrading to pyviz_comms==3.0.4 our internal setup complains about having a new environment variable _PYVIZ_COMMS_INSTALLED that seems to be added in #123 PR. We wanted to understand what was the intention for this and is it needed for some functionality to work?

Also, is it supposed to be set only in all non-Jupyter environments e.g. Python process, IPython but not Jupyterlab.

cc: @philippjfr

@hoxbro
Copy link
Member

hoxbro commented Jan 21, 2025

is it needed for some functionality to work.

Not right now. But at some point, it will likely be used in Panel to check if the environment launching Jupyter Lab has pyviz_comms installed in it.

Also, is it supposed to be set only in all non-Jupyter environments e.g. Python process, IPython but not Jupyterlab.

Yes. The environment variables should not be set when importing pyviz_comms inside Jupyterlab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants