Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ping shows green color on error status codes #1832

Closed
MartinLoeper opened this issue Jan 1, 2025 · 2 comments
Closed

bug: ping shows green color on error status codes #1832

MartinLoeper opened this issue Jan 1, 2025 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@MartinLoeper
Copy link

Describe the bug

I configured ping for my applications and they display the status code as expected when hovering. However, the color does not change to red once a non-200 status code is received.

Steps to reproduce

  • configure a ping for an app
  • make the ping fail by e.g. changing the ping url to a 404 page
  • check the color of the ping indicator on your board

Impact

The ping indicator on each app tile has limited usefulness because I have to hover it to see the status code to determine whether the app is alive.

Additional information

Screenshot From 2025-01-01 19-53-50

Version

1.0.0-beta

Installation method

Docker Run

Browser

Firefox

@manuel-rw
Copy link
Member

manuel-rw commented Jan 2, 2025

This is expected behavior. The "ping" functionality was never intended to check for status codes. Back in 2022, this feature was introduced without much discussion around it. Homarr's purpose is not to monitor the uptime of your apps or whether they are healthy. The name "ping" also implies that only the connection is tested - which was untrue in <1.0 but now true in 1.0.
I understand your desire though and we are planning to add proper monitoring after the public release of 1.0. We will add support for Uptime Kuma (and more similar tools in iterative steps, see ajnart/homarr#2241), which will enable you to monitor much more than just HTTP(-S) links. Uptime Kuma can also monitor databases, TCP connections, popular game servers, docker containers and more! Most of our users already use it anyway, so it's a good idea to re-use and integrate it into Homarr - like we do with many other integrations.

As a summary; all status codes will be displayed as "green" in 1.0 any only connections that could not be established will be shown as "red". Support for better monitoring integration(-s) will follow.

@manuel-rw manuel-rw added wontfix This will not be worked on bug Something isn't working and removed needs triage labels Jan 2, 2025
@manuel-rw manuel-rw closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
@MartinLoeper
Copy link
Author

Understandable. Thanks for the clarification @manuel-rw. It is not a crucial feature for me anyway. I was just surprised as the color and the status code tooltip suggested to me that there might be a status code check intended. which is not the case as you explained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants