Twitch integration uses excessive API requests

[qwell]

The problem

Many of the Helix API requests (e.g. get-streams, get-channel-followers, and get-followed-channels) offer pagination. I follow about 120 channels, which ends up being somewhere in the area of 500 API requests and takes about 3 minutes to update every channel.

For me, the number of API requests could be reduced by 75% by adding pagination. Further, if usage of check-user-subscription (no pagination available) became a config option, the number of API requests would be reduced to only about 10.

What version of Home Assistant Core has the issue?

core-2024.10.3

What type of installation are you running?

Home Assistant OS

Integration causing the issue

twitch

[qwell]

I'm wrong about get_streams; it would need to switch to get_followed_streams to get pagination (get_streams works on all streams on the platform and removing broadcaster_id there would just be a massive list).

I took a crack at this, but async Python breaks my brain and I gave up. Taking get_channel_followers and get_followed_streams out of the self.users loop did seem to work though -- you just need to remove channel.id and change/remove the first param.

[joostlek]

I mean I am happy to help you out where needed. I use Twitch not that often so it's not that high on my priority list (which is long), so if I can help you out with that, that would be awesome

[home-assistant]

twitch documentation
twitch source

[qwell]

I can open a half-baked PR this evening. It won't be right, but it'll be close. It should reduce API calls by about 50% the way I did it.

…

On Mon, Oct 21, 2024, 2:43 PM home-assistant[bot] ***@***.***> wrote: twitch documentation <https://www.home-assistant.io/integrations/twitch> twitch source <https://github.com/home-assistant/core/tree/dev/homeassistant/components/twitch> — Reply to this email directly, view it on GitHub <#128866 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFUDNOZTYSDZCJKF7FJVDDZ4VDNNAVCNFSM6AAAAABQJACQG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRXGQ2TSMRQHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[joostlek]

Also be aware, something got merged that centralizes the api calls, so there already is a difference between 2024.10 and dev. It probably won't be fabulous, since we need to store all the data in 1 entity (which I want to split up, hence I centralized the data fetching)