Wrong assertion in GainTemplate tests

[giuspugl]

the result detdata key

toast/src/toast/ops/mapmaker.py

Line 556 in 44d9f84

result = Unicode(

should encode the TOD calibrated, i.e. corrected by the gain fluctuations , expressed as the linear combination of Legendre polinomials weighted by the amplitudes estimated by the toast mapmaker.
Instead the test

toast/src/toast/tests/template_gain.py

Line 83 in 44d9f84

np.testing.assert_allclose(

asserts exactly that the result data to be an array of np.ones local samples.
What we should compare to be close to 1 should be instead the ops.Calibrate.template_matrix.templates[0].data['calibrator_solve_amplitudes']

[giuspugl]

Also in

toast/src/toast/ops/mapmaker_templates.py

Line 1009 in 44d9f84

combine = Combine(op=self.op, first=self.det_data, second=projected)

what we should be dividing is not the template by the uncalibrated signal but the fitted gain amplitudes.
Similarly to what we do in

toast/src/toast/todmap/mapmaker.py

Line 411 in ddae67d

def calibrate(self, signal, amplitudes):