Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed things up #50

Open
linsea opened this issue Mar 30, 2017 · 6 comments
Open

speed things up #50

linsea opened this issue Mar 30, 2017 · 6 comments

Comments

@linsea
Copy link

linsea commented Mar 30, 2017

hi, how about the performance compare with others? any benchmark?

@Albul
Copy link

Albul commented Jan 8, 2020

@linsea Here I have created couple with graphs:
https://github.com/Albul/benchmarks-java-kotlin

@hrldcpr
Copy link
Owner

hrldcpr commented Jan 8, 2020

Thanks @Albul that's really useful! Looks like there's lots of room for improvement in TreePVector.

And good to know about the ConsPStack recursion bugs, I'll make sure that's fixed in #75

@Albul
Copy link

Albul commented Jan 9, 2020

@hrldcpr thanks.
Also measurements in terms of size:
https://github.com/Albul/sizeof-objects-java

It seems quite big usage, maybe because of using long key in IntTree

@hrldcpr
Copy link
Owner

hrldcpr commented Jan 10, 2020

Awesome thanks, that's very interesting and useful data

@hrldcpr hrldcpr changed the title how about the performance? speed things up Jan 10, 2020
@hrldcpr
Copy link
Owner

hrldcpr commented Jan 30, 2020

@Albul fyi the latest release—PCollections v3.1.3—fixes the stack overflow bugs you found, so if it's not too much trouble to re-run your benchmarks with the new version, I'd love to see the results

@hrldcpr
Copy link
Owner

hrldcpr commented Oct 29, 2022

@BomBardyGamer shared another set of benchmarks, which could also be useful for speeding things up
https://github.com/JohnnyJayJay/persistent-data-structures-benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants