Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[需求] Is better for FastBeanCopier change CACHE type to ConcurrentReferenceHashMap #186

Open
Taoaozw opened this issue Dec 1, 2021 · 4 comments
Assignees
Labels

Comments

@Taoaozw
Copy link

Taoaozw commented Dec 1, 2021

f in a scenario where the key changes frequently,ConcurrentHashMap takes up a lot of invalid memory

@zhou-hao
Copy link
Member

zhou-hao commented Dec 1, 2021

I don't think so ,Creating Copier is time-consuming, and using ConcurrentHashMap may speed up program crashes!

@Taoaozw
Copy link
Author

Taoaozw commented Dec 1, 2021

I don't think so ,Creating Copier is time-consuming, and using ConcurrentHashMap may speed up program crashes!

emmm, maybe you say ConcurrentReferenceHashMap will speed up program crashes ?
FastBeanCopier exactly use ConcurrentHashMap here !
You have a point, It's cost-effective to have high performance requirements ! But the situations of out-of-memory situations also need to be considered , is there can provider a choose .
截屏2021-12-01 下午4 51 49

@zhou-hao
Copy link
Member

zhou-hao commented Dec 1, 2021

You are right , It should be configurable , can you pull request to do it ?

@Taoaozw
Copy link
Author

Taoaozw commented Dec 1, 2021

Thanks for your invitation , i will try do this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants