Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libfvad does not build and possible solutions for VAD problems #12

Open
DatSpace opened this issue Aug 5, 2022 · 2 comments
Open

Libfvad does not build and possible solutions for VAD problems #12

DatSpace opened this issue Aug 5, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@DatSpace
Copy link
Collaborator

DatSpace commented Aug 5, 2022

Libfvad, the webrtc library we were using for VAD seems to be stale for a while and it has problems building on ubuntu 22. Further than that, it seems to be based off an old commit of the webrtc library. A quick search for webrtcvad (The old python version we were using) shows that the fork is around 2016.

https://github.com/wiseman/py-webrtcvad

And : wiseman/py-webrtcvad#69

To be fair we are using the CPP version which even though we had performance improvements, we still had a lot of false positives.
https://github.com/dpirch/libfvad

Proposed solutions:

  • Obviously the microphone plays an important role so as discussed we can look more into that.

  • Try and maintain our own fork of libfvad OR create a fork directly from google's webrtc (cpp) to use in the project.

  • Switch back to Python (this time, multi-threaded) using an alternative like https://github.com/snakers4/silero-vad#vad-quality-metrics-methodology

@DatSpace DatSpace added bug Something isn't working enhancement New feature or request labels Aug 5, 2022
@DatSpace
Copy link
Collaborator Author

DatSpace commented Aug 9, 2022

The problem was that the configuration for autoreconf had a "patch" for the previous version of autoreconf that was fixed in the latest version. Ubuntu 22 comes with the latest version of the software so there was a mismatch.

In any case, fixed with b05afcd

@DatSpace DatSpace closed this as completed Aug 9, 2022
@DatSpace DatSpace reopened this Aug 9, 2022
@DatSpace
Copy link
Collaborator Author

DatSpace commented Aug 9, 2022

I will actually leave it open as it can be used as a reminder for possibly upgrading the VAD in the future. The issue is fixed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant