-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling getRef().delete() does not respect the base URL set in .withEndpoint() #1974
Comments
@ajmalab It sounds like you're trying to run local test server. To do that you need to modify the response body to replace api.github.com with We use
Which then calls
|
@bitwiseman Here's the returned response for getRef():
|
It sounds like you're saying the body information isn't consistent with your server URLs. The scenario you're describing is out of scope for this library. You are welcome to submit a PR to try and address it but we do not have the bandwidth. |
Describe the bug
Calling
getRef().delete()
does not respect the base URL set in .withEndpoint() when creating the OAuth client. It usesapi.github.com
by default. While this would work in production, it blocks the ability to test this endpoint using local mock servers.To Reproduce
Steps to reproduce the behavior:
https://api.github.com
and nothttp://localhost:8080
.Expected behavior
The
getRef().delete()
method should respect the base URL passed in viawithEndpoint()
like the other chained methods ofgetRepository()
.Additional context
Library version: 1.321
The text was updated successfully, but these errors were encountered: