Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow read_config_file() and read_config() to take URLs as inputs and add SubTreeFileSystem class method to read_config_file() #209

Closed
annakrystalli opened this issue Feb 4, 2025 · 1 comment · Fixed by #210
Assignees

Comments

@annakrystalli
Copy link
Member

See https://github.com/hubverse-org/hubValidations/pull/196 fo for context

@annakrystalli
Copy link
Member Author

Actually this is a bit more involved given we currently support both s3 bucket paths and local paths. I was trying to avoid having to class specific methods of read_config_file() as the idea was that it would primarily be called via read_config() which does have class methods and performs a lot of validation also. However, I'm going to go ahead and add class specific methods to read_config_file(). In the default method, I'll also allow it to read a config file from a url (e.g. GitHub) which would allow modelers not working within a hub to have an up to date version of a config file.

@annakrystalli annakrystalli moved this from Todo to In Progress in hubverse Development overview Feb 4, 2025
@annakrystalli annakrystalli self-assigned this Feb 5, 2025
@annakrystalli annakrystalli changed the title Add file extension check to read_config_file() Allow read_config_file() and read_config() to take URLs as inputs and add SubTreeFileSystem class method to read_config_file() Feb 5, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in hubverse Development overview Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant