You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These should be exposed as settings so that users can still set these values without the defines (in case removing them makes sense for their project, e.g. they calculate the value at compile-time some other way). If the defines are parsed the settings can be visible but disabled, with text directing the user to their project file.
I think the real value of doing this is visibility. Unless you dig into the manual it's not clear Porymap will respect changes to these values.
The text was updated successfully, but these errors were encountered:
Porymap reads a handful of defines that it needs values for. If it fails to find them it enforces a default value:
porymap/src/project.cpp
Lines 28 to 36 in 49cb69f
These should be exposed as settings so that users can still set these values without the defines (in case removing them makes sense for their project, e.g. they calculate the value at compile-time some other way). If the defines are parsed the settings can be visible but disabled, with text directing the user to their project file.
I think the real value of doing this is visibility. Unless you dig into the manual it's not clear Porymap will respect changes to these values.
The text was updated successfully, but these errors were encountered: