Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editing missing project defines #562

Open
GriffinRichards opened this issue Dec 14, 2023 · 0 comments
Open

Support editing missing project defines #562

GriffinRichards opened this issue Dec 14, 2023 · 0 comments

Comments

@GriffinRichards
Copy link
Collaborator

Porymap reads a handful of defines that it needs values for. If it fails to find them it enforces a default value:

porymap/src/project.cpp

Lines 28 to 36 in 49cb69f

int Project::num_tiles_primary = 512;
int Project::num_tiles_total = 1024;
int Project::num_metatiles_primary = 512;
int Project::num_metatiles_total = 1024;
int Project::num_pals_primary = 6;
int Project::num_pals_total = 13;
int Project::max_map_data_size = 10240; // 0x2800
int Project::default_map_size = 20;
int Project::max_object_events = 64;

These should be exposed as settings so that users can still set these values without the defines (in case removing them makes sense for their project, e.g. they calculate the value at compile-time some other way). If the defines are parsed the settings can be visible but disabled, with text directing the user to their project file.

I think the real value of doing this is visibility. Unless you dig into the manual it's not clear Porymap will respect changes to these values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant