Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with themes #577

Open
1 of 6 tasks
GriffinRichards opened this issue Jan 3, 2024 · 0 comments
Open
1 of 6 tasks

Issues with themes #577

GriffinRichards opened this issue Jan 3, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@GriffinRichards
Copy link
Collaborator

GriffinRichards commented Jan 3, 2024

  • Poor tab styling in dark modes (See Improve tab style in dark modes #561)
  • Placeholder text color isn't updated when the theme changes (See Placeholder text color doesn't update correctly with theme change #560). QPalette::PlaceholderText or placeholder-text-color are useful for this
  • URL color contrast on dark themes is still bad on Windows. Fixed: eecdd8c
  • We have no actual "Light" theme mode, just a "Default" which can be overridden by the system theme. A consequence for this is that it's not possible for a user to have Porymap in a Light theme if it disagrees with their system theme. If we accept system themes we may wish to detect dark mode and switch to our dark mode stylesheet automatically instead.
  • On newer versions of macOS the Default theme doesn't change the appearance of QComboBox dropdown handles if they're disabled, so they appear identical to enabled QComboBoxs with placeholder text:

disabled

  • Changing to the Default theme retains some incorrect colors. See image (apparently just QScrollArea on Windows, not reproducible on macOS)

image

@GriffinRichards GriffinRichards added bug Something isn't working enhancement New feature or request labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant