This repository has been archived by the owner on Oct 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempts a fix for #196
Checklist
1.1 Naming parameters as native solidity datatypes should lead to an error
#define function balanceOf(address uint256) view returns (uint256 balance)
=> now errors with:1.2 A lack of a comma in a function definition should not lead to following datatypes affecting the function signature
2. You should be allowed to give a parameter a name that starts with "int" / "uint" / "bytes"
PrimitiveEVMType
that optimistically unwrapped on parsing the remaining bit of a string as ausize
.3. You should be able to name dynamic parameters (
string
,bytes
,<type>[]
, etc.)