Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split_batches argument in Accelerator.__init__ is available, but not used #3177

Open
yaraksen opened this issue Oct 17, 2024 · 0 comments
Open

Comments

@yaraksen
Copy link

yaraksen commented Oct 17, 2024

System Info

accelerate==1.0.1

Reproduction

Since the latest versions split_batches is taken from DataLoaderConfiguration, but still can be passed as an argument to Accelerator constructor, which leads to unexpected behavior.
You can pass Accelerator(split_batches=True), but it will still be False

Expected behavior

There should not be 2 different places where argument can be passed or an exception should be raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant