Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated appdata doesn't contain an icon when id doesn't contain .desktop suffix #463

Open
ilya-fedin opened this issue Nov 25, 2022 · 0 comments

Comments

@ilya-fedin
Copy link

ilya-fedin commented Nov 25, 2022

It seems #209 is still present, at least with some app ids. We're encountering it at https://github.com/flathub/org.telegram.desktop. We sadly can't use <launchable> tag as it's just not known at build time what the desktop id will be as both snap and flatpak rename .desktop and .metainfo.xml files according to their rules. It seems the specification doesn't define how exactly the desktop id should be discovered, could it ignore the <id> tag and use the app_name?

Like

		if (launchable != NULL) {
			desktop_basename = g_string_new (as_launchable_get_value (launchable));
		} else {
			desktop_basename = g_strconcat (app_name, ".desktop", NULL);
		}

It would also be ok if the g_str_has_suffix check is just removed I guess, I just don't see how to make both flatpak and snap happy otherwise...

gasinvein added a commit to gasinvein/org.telegram.desktop that referenced this issue Nov 25, 2022
Should fix collecting icons until hughsie/appstream-glib#463 is resolved
or flatpak switches to another appstream library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant