Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined index: REQUEST_METHOD when running integration tests #622

Open
johnbillion opened this issue May 12, 2022 · 3 comments
Open

Undefined index: REQUEST_METHOD when running integration tests #622

johnbillion opened this issue May 12, 2022 · 3 comments
Labels
bug Existing functionality isn't behaving as expected should have Should be done, medium priority for now to refine Issues needing refine

Comments

@johnbillion
Copy link
Member

johnbillion commented May 12, 2022

When running an integration test suite set up via the Testing with Codeception docs, the performance_optimizations module triggers a PHP notice:

Undefined index: REQUEST_METHOD in /usr/src/app/vendor/altis/cloud/inc/performance_optimizations/namespace.php on line 30

Steps to reproduce:

  1. Set up an integration test suite
  2. Run the tests with composer dev-tools codecept run
  3. Observe the error above

Using Altis 11.

@johnbillion johnbillion added the bug Existing functionality isn't behaving as expected label May 12, 2022
@johnbillion johnbillion changed the title Undefined index: REQUEST_METHOD when running acceptance tests Undefined index: REQUEST_METHOD when running integration tests May 12, 2022
@roborourke
Copy link
Contributor

Thanks for the report @johnbillion, what's the severity in terms of your tests? Surprising that this isn't populated by the WP test framework tbh.

@roborourke roborourke added the should have Should be done, medium priority for now label May 13, 2022
@johnbillion
Copy link
Member Author

It doesn't impact the running, just makes the output noisy.

@johnbillion
Copy link
Member Author

And agreed, I would expect this value to be populated by the test framework.

@veselala veselala added to refine Issues needing refine and removed to-refine-dev labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected should have Should be done, medium priority for now to refine Issues needing refine
Projects
None yet
Development

No branches or pull requests

3 participants