Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoast social images use all attachments with filesize #151

Open
joehoyle opened this issue Nov 19, 2021 · 0 comments
Open

Yoast social images use all attachments with filesize #151

joehoyle opened this issue Nov 19, 2021 · 0 comments

Comments

@joehoyle
Copy link
Member

When building the index for attachments (and quite possibly in other areas too), Yoast will filter the attachment image sizes (by default full, large, medium_large) by filesize (see https://github.com/Yoast/wordpress-seo/blob/trunk/inc/class-wpseo-image-utils.php#L340) to exclude anything that is over 2MB.

In conjunction with S3 uploads, this makes these functions very slow, as each image has to be pulled from S3 in full to check it's file size.

Rather than using the image sizes at all, in Altis it seems we should just be passing a tachyon image somehow and not going any of those checks etc.

@joehoyle joehoyle changed the title Yoast social images use all attachemnts with filesize Yoast social images use all attachments with filesize Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant