Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document using Yoast Premium's redirects instead of ours #59

Open
1 task
jazzsequence opened this issue May 11, 2021 · 2 comments
Open
1 task

Document using Yoast Premium's redirects instead of ours #59

jazzsequence opened this issue May 11, 2021 · 2 comments
Labels
could have Could be done, or nice to have, low priority for now task An item with a singular purpose and clearly defined path forward

Comments

@jazzsequence
Copy link
Contributor

jazzsequence commented May 11, 2021

If a Yoast license key exists, users can use Yoast SEO redirects instead of our own. We should document this.

Acceptance Criteria:

  • Document disabling Altis redirects in favour of Yoast's redirects
@jazzsequence jazzsequence added the task An item with a singular purpose and clearly defined path forward label May 11, 2021
@jazzsequence
Copy link
Contributor Author

This also requires that we actually have a copy of the premium plugin to test this (which I do not).

@roborourke
Copy link
Contributor

You can grab credentials and composer set up from one of our internal private project repos or alternatively I think the creds should should be in 1pass. Ping me in Slack if you need a pointer.

I think rather than checking for a license key (there are few ways that could be provided I think) I believe the plugin itself has some helper function last I checked, like is_premium() or something. Or you could check for the existence of the Yoast redirect code directly.

Given this is specific to Yoast premium a subcommand of wp altis migrate like you suggest would make sense. Would need to look into how Yoast SEO stores and handles redirects to know exactly how to do this.

I'd probably mark this as a could have as both could exist side by side without any problem.

@jazzsequence jazzsequence added the could have Could be done, or nice to have, low priority for now label May 13, 2021
@rmccue rmccue changed the title Task: Unload humanmade/redirects if Yoast Premium is active Document using Yoast Premium's redirects instead of ours Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could have Could be done, or nice to have, low priority for now task An item with a singular purpose and clearly defined path forward
Projects
None yet
Development

No branches or pull requests

3 participants