Broken layout for printing

[Drivingralle]

Hey!

I checked how the layout looks like if you print it using the mac feature to "print to PDF".
And it doesn't look to bad, but menu and header stuff is disturbing.
https://cloudup.com/ct-rjX520xQ

For one of my projects we are thinking about using the theme for our own handbook. We require the ability to print (to PDF) - don't ask ...

I'm happy to contribute the required CSS. Therefore I would like to know what way the maintainer likes it to be implemented: As separate print.css file or as media query in the theme.css file

Greetings
derRALF

[mattheu]

Print stylesheet would be awesome. I'd be happy with either really. Perhaps a _print.scss partial + media query would be neatest?

[Drivingralle]

I have tried to setup the theme on my lokal dev system.
Checkout out the master branch of the theme and manual checkout the pattern lib into the vendor folder.

As I'm now running gulp on the theme folder I get the following error message:

[19:10:56] Using gulpfile ~/handbook-git/wp-content/themes/hm-handbook-theme/gulpfile.js
[19:10:56] Starting 'styles'...
[19:10:57] Finished 'styles' after 16 ms
[19:10:57] Starting 'js'...
[19:10:57] Starting 'lint-sass'...
Error in plugin 'sass'
Message:
    assets/src/styles/login.scss
Error: File to import not found or unreadable: ./../../../vendor/hm-pattern-library/assets/sass/style
       Parent style sheet: /handbook-git/wp-content/themes/hm-handbook-theme/assets/src/styles/login.scss
        on line 4 of assets/src/styles/login.scss
>> @import "./../../../vendor/hm-pattern-library/assets/sass/style";
   ^

[19:11:04] Finished 'lint-sass' after 7.48 s
[19:11:08] Finished 'js' after 12 s
[19:11:09] Starting 'default'...
[19:11:09] Finished 'default' after 9.15 μs

Can someone help me out so I can start working on the print styles?

[mattheu]

Can you try running git submodule update? It includes some HM brand stuff from a submodule hm-pattern-library and I suspect that if these are not found then there is something up there.

[Drivingralle]

I run git submodule update from the theme folder and get the following:

Computer:hm-handbook-theme drivingralle$ git submodule update
Cloning into '/wp-content/themes/hm-handbook-theme/vendor/hm-pattern-library'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:humanmade/hm-pattern-library.git' into submodule path '/wp-content/themes/hm-handbook-theme/vendor/hm-pattern-library' failed
Failed to clone 'vendor/hm-pattern-library'. Retry scheduled
Cloning into '/wp-content/themes/hm-handbook-theme/vendor/hm-pattern-library'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

[mattheu]

Ah I'll need to change the remote url used to the http one not the git@. I'll do this for you.

[mattheu]

Try pulling master now, then run git submodule sync then git submodule update again.

[Drivingralle]

Submodule update works now.
Gulp also works.

Thanks @mattheu!

I guess will get to working on the issue next week.

[willmot]

@Drivingralle did you make any progress on this by any chance?

[Drivingralle]

@willmot I haven't found the time to work on it.
We are still interested in the feature.