Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find solution for dealing with non ASCII domains #18

Open
fklein-lu opened this issue Jun 15, 2018 · 1 comment
Open

Find solution for dealing with non ASCII domains #18

fklein-lu opened this issue Jun 15, 2018 · 1 comment
Milestone

Comments

@fklein-lu
Copy link
Contributor

Currently there's no good way to handle internationalised domains that use non ASCII characters. Characters can either be displayed, or encoded characters might be used.

We should align on a safe, reliable storage mechanism. One possible direction to investigate would be to use Core's Requests_IDNAEncoder class.

@fklein-lu fklein-lu added this to the 1.0 milestone Jun 15, 2018
@fklein-lu
Copy link
Contributor Author

After talking to @rmccue, we decided to use the Internationalized Domain Names in Applications (IDNA) Protocol, as outlined in RFC 5891.

Storage

Both the From and To URLs will be stored as absolute URLs in IDNA encoded format. Redirect matching will be done via IDNA encoded URLs as well.

Options for implementing the IDNA encoding:

  • Use the Requests_IDNAEncoder class in WordPress.
  • Use the true/punycode Composer package.

UI

The UI should display the decoded URLs, to reduce confusion among users. But the UI should also offer a way to view the IDNA encoded variation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant