Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on startup if apiserver is unreachable #616

Open
ryanfaircloth opened this issue Sep 2, 2022 · 2 comments
Open

Panic on startup if apiserver is unreachable #616

ryanfaircloth opened this issue Sep 2, 2022 · 2 comments

Comments

@ryanfaircloth
Copy link
Contributor

func initMode() {

In some cluster deployments a condition can occur where an init container connecting to the api server very quickly can receive a connection error. "Connection refused" and "500" errors should be retry-able for a configurable amount of time, default to 60s with 2s sleep

@SaaldjorMike
Copy link
Member

I guess the main benefit here would be to retry things based on our own retry logic vs having to rely on container restarts which would also retry those requests, but overall I'm not sure this is super critical. It is obviously "nicer" to retry and not panic, but if you have a k8s setup with a ton of connection issues or so when talking to the api server, then its probably more important to fix those issues.

@ryanfaircloth
Copy link
Contributor Author

this actually came up in EKS where aws handles scale of the control plane. Sometimes its just transient network issues other times it could be a delay in the cni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants