Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobScheduler Improvements #30

Closed
thoven87 opened this issue Sep 16, 2024 · 4 comments
Closed

JobScheduler Improvements #30

thoven87 opened this issue Sep 16, 2024 · 4 comments

Comments

@thoven87
Copy link
Contributor

1 - Investigate using JobQueue push to push jobs onto a queue

2 - I think the Metadata needs updated to use JobName -> last run (or scheduled) instead of _jobScheduleLastDate It's a little confusing right now if one has more than one scheduled job

Ex: StatsJob runs every 5 minutes
KPI runs everyday @12 AM UTC

@adam-fowler
Copy link
Member

1 - Investigate using JobQueue push to push jobs onto a queue

2 - I think the Metadata needs updated to use JobName -> last run (or scheduled) instead of _jobScheduleLastDate It's a little confusing right now if one has more than one scheduled job

Ex: StatsJob runs every 5 minutes

KPI runs everyday @12 AM UTC

Is 1 the same issue as you mentioned earlier?

2 we should only need one last scheduled date for all jobs. It is basically the date we last scheduled something. And at init every schedule should base itself off that. It could be renamed to lastDateJobScheduled which makes slightly more sense.

@adam-fowler
Copy link
Member

Is 1 the same issue as you mentioned earlier?

I see it is not. It still eventually goes through JobQueue.push, but it needs to go through the extension of JobParameters as it needs a concrete JobParameters instead of the existential reference we have in the element returned by JobSequence

@thoven87
Copy link
Contributor Author

thoven87 commented Sep 16, 2024

1 - Investigate using JobQueue push to push jobs onto a queue
2 - I think the Metadata needs updated to use JobName -> last run (or scheduled) instead of _jobScheduleLastDate It's a little confusing right now if one has more than one scheduled job
Ex: StatsJob runs every 5 minutes
KPI runs everyday @12 AM UTC

Is 1 the same issue as you mentioned earlier?
Yes, it is the same issue mentioned in the comment here

2 we should only need one last scheduled date for all jobs. It is basically the date we last scheduled something. And at init every schedule should base itself off that. It could be renamed to lastDateJobScheduled which makes slightly more sense.

I see! The scheduled job itself can manage the last time it ran and generate a revision id.

@thoven87
Copy link
Contributor Author

Is 1 the same issue as you mentioned earlier?

I see it is not. It still eventually goes through JobQueue.push, but it needs to go through the extension of JobParameters as it needs a concrete JobParameters instead of the existential reference we have in the element returned by JobSequence

You're correct, I will continue debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants