Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate blueprint swap criteria and implementation #229

Open
pheuberger opened this issue Jan 28, 2025 · 0 comments
Open

Reevaluate blueprint swap criteria and implementation #229

pheuberger opened this issue Jan 28, 2025 · 0 comments

Comments

@pheuberger
Copy link
Member

The current implementation for querying collection.blueprints.hypercerts seems unclear and may not fully align with intended use cases. Discussions suggest that:

Blueprints fetched via the query may not represent the hypercerts that a collection admin wants in their collection.
The current swapping mechanism (where a blueprint is replaced with a minted hypercert) introduces complexity and may invalidate the purpose of the query in certain scenarios.
There’s a need to revisit the logic for when a blueprint is swapped out, potentially limiting swaps to cases where the metadata is an exact match.

See this thread for more context:
#214 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant