Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperlane warp check does not handle gas #5572

Open
ltyu opened this issue Feb 26, 2025 · 0 comments
Open

hyperlane warp check does not handle gas #5572

ltyu opened this issue Feb 26, 2025 · 0 comments

Comments

@ltyu
Copy link
Contributor

ltyu commented Feb 26, 2025

Problem

Currently, when we run hyperlane warp check we receive a false positive:
Image

This is a false positive because gas is set in this case by because the destinationGas is set.

Note that the gas is used to set the destinationGas value in the other chains. For example, if base.gas is set to 200000, then we need to check the value of ethereum.destinationGas.base.

Solution

Ensure that if gas is given in the config, that it is compared to the correct destinationGas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant