-
Notifications
You must be signed in to change notification settings - Fork 142
Ursa is out of policy for license and copyright indications #167
Comments
I know in the JS/TS ecosystem that there are linters that can help with this issue. On a quick search I wasn't seeing any features of clippy that support it. Does anyone (pinging @dhuseby ) know of one that I didn't spot? |
Tell me, is this header format helpful, or should we use the full license in addition to it? |
I think this looks excellent |
That's amazing you picked up this issue from 2020! ❤️ In general you may be able to tell where the code came from using the commit history or looking at the existing headers. Otherwise you may be able to rely on the maintainers remembering where things came from when they do their code review. |
For now, I've updated the PR, removing some of the excess files and changing the header. I've also reviewed the Ursa development history to understand where to add the headers. |
Thanks for the extra effort @6r1d. I'll defer to more active maintainers on how they would like to review. One possibility would be to break the commit into one commit per module and then target the review at the principal author for that module so that they can acknowledge the license is accurate. I think in most cases that might just boil down to our intrepid @mikelodder7 :) ... in which case maybe splitting up the commit is not necessary. |
While the LICENSE file is accurate, each source file is required to start with a license banner. Only about a dozen files do.
Please see: https://wiki.hyperledger.org/display/TSC/Copyright+and+License+Policy
The text was updated successfully, but these errors were encountered: