Implement funding and watching service over tcp+perun's protobuf encoding. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 14, 2023 14:13
Signed-off-by: Manoranjith <[email protected]>
- The filesToMove array was not populated. Hence, the directories were empty. To fix, populate this array properly. - The idProvider.yml include only the own alias. To fix, modify the logic to include everything except own alias. Signed-off-by: Manoranjith <[email protected]>
- Change build command to install. This installs the binaries in $GOBIN directory. - Add generate command that generates the artefacts for demo. Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
- Previously, the nested map was not initialized. This caused a panic when Register was invoked. - Initializing the map fixes this it. Signed-off-by: Manoranjith <[email protected]>
- ETH asset is registered by default already during the initialization fo the funder. Signed-off-by: manoranjith <[email protected]>
- The key can be used for initializing pre-funded accounts in ganache-cli or for initializing the same keys for tests in alternate clients (like rust implementation). Signed-off-by: manoranjith <[email protected]>
- Add a flag to run command to specify the service to run. - Split the serve function in gprc package. Signed-off-by: Manoranjith <[email protected]>
- This is a temporary workaround to enable the existing version of perunnode-cli to connect with the API in fundwatch only mode to generate a session-id by opening a session. - Once, the perunnode-cli is updated, this can be undone. Signed-off-by: Manoranjith <[email protected]>
- The extracted handlers use in golang standard context, protobuf request/response messages. - Hence, these can be shared between grpc and other upcoming implementations (like peruniotcp server). Signed-off-by: Manoranjith <[email protected]>
manoranjith
force-pushed
the
perunio-api
branch
from
d802cd5 to
461cb54
Compare
- The extracted handlers use in golang standard context, protobuf request/response messages. - Hence, these can be shared between grpc and other upcoming implementations (like peruniotcp server). Signed-off-by: Manoranjith <[email protected]>
manoranjith
force-pushed
the
perunio-api
branch
2 times, most recently
from
6899640 to
4946237
Compare
added 2 commits
December 14, 2023 17:07
- Define a api_messages.proto as a enum of all the funding and watching services. - This is needed, for parsing of the request, because unlike grpc, tcp adapter using perunio's custom messaging scheme does not have an in-built routing mechanism. Signed-off-by: manoranjith <[email protected]>
- Also combine the commands for watching and funding service, because the api_messages.proto depends on both of these definitions. Signed-off-by: manoranjith <[email protected]>
manoranjith
force-pushed
the
perunio-api
branch
from
4946237 to
2083387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement funding and watching service over tcp+perun's protobuf encoding.
Category
Implementation Task
Relevant issue
Testing
Steps to run the tests
Needs to be tested along with an embedded implementation, which will use this API.
This will be documented separately.
Checklist