Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use caching CI builds #762

Merged
merged 2 commits into from
May 17, 2024
Merged

Use caching CI builds #762

merged 2 commits into from
May 17, 2024

Conversation

osamamagdy
Copy link
Contributor

@osamamagdy osamamagdy commented May 7, 2024 •
edited
Loading

Fixes #753
This PR activates caching on a directory on the runner and mounting it to the go location where dependencies are installed inside the container building the app

@osamamagdy osamamagdy marked this pull request as ready for review May 7, 2024 19:59
@osamamagdy osamamagdy requested a review from a team as a code owner May 7, 2024 19:59
@osamamagdy osamamagdy marked this pull request as draft May 7, 2024 20:13
@osamamagdy osamamagdy mentioned this pull request May 9, 2024
Open
3 tasks
mbrandenburger
mbrandenburger reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@mbrandenburger mbrandenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. I've tested it locally and it works great!
Could you please check my suggestions. We should also document this "option" in the config.mk.

utils/docker/Makefile Outdated Show resolved Hide resolved
utils/docker/Makefile Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@osamamagdy
Copy link
Contributor Author

@mbrandenburger thanks for your time to review. All changes applied and now the PR is ready 🙂

@osamamagdy osamamagdy marked this pull request as ready for review May 16, 2024 16:09
@mbrandenburger
Copy link
Contributor

mbrandenburger commented May 16, 2024 •
edited
Loading

@osamamagdy thanks for the updates. Could you please rebase/squash your changes. I think we keep one commit for the workflow_dispatch and another one for caching go mod cache. WDYT?

@osamamagdy osamamagdy force-pushed the feature/ci-caching branch 2 times, most recently from 969a940 to daa25b3 Compare May 17, 2024 14:55
@osamamagdy
feat: mount gomod caching
481ced9 
Signed-off-by: osamamagdy <[email protected]>
mbrandenburger
mbrandenburger requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@mbrandenburger mbrandenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've noticed those whitespaces. Otherwise this looks very good to me.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@osamamagdy osamamagdy force-pushed the feature/ci-caching branch 2 times, most recently from 01da46b to 9870332 Compare May 17, 2024 15:01
@osamamagdy
Copy link
Contributor Author

osamamagdy commented May 17, 2024 •
edited
Loading

@mbrandenburger Thanks, all done now

@mbrandenburger mbrandenburger self-assigned this May 17, 2024
mbrandenburger
mbrandenburger approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@mbrandenburger mbrandenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Thanks!

@mbrandenburger mbrandenburger merged commit 2a1db79 into hyperledger:main May 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munapower munapower munapower approved these changes

@mbrandenburger mbrandenburger mbrandenburger approved these changes

Assignees

@mbrandenburger mbrandenburger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use caching CI builds
3 participants
@osamamagdy @mbrandenburger @munapower