Set the fine structure coefficients only if not already set when adding `EELSCLEdge` to a model #67

francisco-dlp · 2024-07-09T06:32:19Z

Description of the change

Fix a regression that resets the fine_structure_coeff when adding a EELSCLEdge to an EELSModel.

Progress of the PR

Change implemented (can be split into several points),
added tests,
add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
ready for review.

Minimal example of the bug fix or the new feature

import exspy
import numpy as np
s = exspy.signals.EELSSpectrum(np.arange(100).reshape(10,10))
# Your new feature...

codecov · 2024-07-09T06:44:37Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.30%. Comparing base (770f06f) to head (8d29439).
Report is 86 commits behind head on main.

Files with missing lines	Patch %	Lines
exspy/models/eelsmodel.py	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   87.77%   87.30%   -0.47%     
==========================================
  Files          67       67              
  Lines        7287     7287              
  Branches     1179     1180       +1     
==========================================
- Hits         6396     6362      -34     
- Misses        626      652      +26     
- Partials      265      273       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

francisco-dlp · 2024-07-09T07:29:57Z

Closing, since it is fixing an inexistent issue.

Set FS coeff only if not already set

8d29439

francisco-dlp added bug Something isn't working bug-fix labels Jul 9, 2024

francisco-dlp closed this Jul 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set the fine structure coefficients only if not already set when adding `EELSCLEdge` to a model #67

Set the fine structure coefficients only if not already set when adding `EELSCLEdge` to a model #67

francisco-dlp commented Jul 9, 2024

codecov bot commented Jul 9, 2024 •

edited

Loading

francisco-dlp commented Jul 9, 2024

Set the fine structure coefficients only if not already set when adding EELSCLEdge to a model #67

Set the fine structure coefficients only if not already set when adding EELSCLEdge to a model #67

Conversation

francisco-dlp commented Jul 9, 2024

Description of the change

Progress of the PR

Minimal example of the bug fix or the new feature

codecov bot commented Jul 9, 2024 • edited Loading

Codecov Report

francisco-dlp commented Jul 9, 2024

Set the fine structure coefficients only if not already set when adding `EELSCLEdge` to a model #67

Set the fine structure coefficients only if not already set when adding `EELSCLEdge` to a model #67

codecov bot commented Jul 9, 2024 •

edited

Loading