Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of aria-pressed for sidebar collapse/expand button #6163

Closed
Tracked by #6151
acelaya opened this issue Feb 1, 2024 · 0 comments · Fixed by #6165
Closed
Tracked by #6151

Incorrect use of aria-pressed for sidebar collapse/expand button #6163

acelaya opened this issue Feb 1, 2024 · 0 comments · Fixed by #6165
Assignees

Comments

@acelaya
Copy link
Contributor

acelaya commented Feb 1, 2024

Part of #6151

The sidebar toggle button has an aria-expanded attribute and an aria-pressed attribute. The aria-pressed attribute does not change state and is not appropriate for this element.

Because this attribute is present some assistive technologies communicate the control as a toggle button, and the presence of this attribute potentially overrides the aria-expanded attribute in some cases (the element was communicated as expanded by NVDA but not by VoiceOver).

The control is also missing an aria-controls attribute that points to the ID of the content that it expands/collapses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant