Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ToastMessages onMessageDismiss prop receive the message object #1273

Open
acelaya opened this issue Sep 27, 2023 · 0 comments
Open

Make ToastMessages onMessageDismiss prop receive the message object #1273

acelaya opened this issue Sep 27, 2023 · 0 comments
Labels

Comments

@acelaya
Copy link
Contributor

acelaya commented Sep 27, 2023

As implemented in #1272, the onMessageDismiss prop is a callback that receives the message to be dismissed id.

This is consistent to how frontend apps have been using this kind of component, but requires duplicating extra logic in order to determine which message was dismissed.

For next major release we want to change this so that the whole message is passed to the callback.

@acelaya acelaya added this to the Version 7 milestone Oct 10, 2023
@acelaya acelaya removed this from the Version 7 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant