Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make allowed_roles key more descriptive #63

Open
sverhoeven opened this issue Mar 23, 2023 · 0 comments
Open

make allowed_roles key more descriptive #63

sverhoeven opened this issue Mar 23, 2023 · 0 comments

Comments

@sverhoeven
Copy link
Member

In PR #56 roles where introduced. Given an application has a certain role then a user with that role is allowed to submit jobs to it.
The role names are now configured with allowed_roles key in the application section of the config file.
The keyallowed_roles can be misinterpreted.

From #56 (review)

In the configuration file, "allowed_roles" sounds like "given the application, you are allowed to have this role", 
whereas strictly speaking it is "given a role, you are allowed to use the application." 
Perhaps "authorized_roles" is better? Or change to "groups" and use "authorized_groups"?

We should find a more descriptive name for allowed_keys. For example:

  1. authorized_roles
  2. required_roles
  3. roles
  4. user_allowed_roles
  5. granted_roles
  6. ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant