Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB_G Coloring Incorrect? #83

Open
LaikaSpaceDawg opened this issue Feb 17, 2025 · 1 comment
Open

RGB_G Coloring Incorrect? #83

LaikaSpaceDawg opened this issue Feb 17, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@LaikaSpaceDawg
Copy link

LaikaSpaceDawg commented Feb 17, 2025

Your problem

RGB_G (which also appears to be the startup color) shows up much more yellow than green.

Your device

LilyGo T-Dongle S3

Language (HID attacks only)

Your DuckyScript

Simple DS for maintenance/programming access:

REM Debugging
REM WIFI_OFF
REM TFT_OFF
REM LED_OFF

LED_OFF

REM Automatically mounts SD card when plugged in
REM Used for maintenance, should not be used in the wild

DEFINE #FILE /lock

IF (FILE_EXISTS() == FALSE) THEN
	LED_G
	REM Mount Entire Contents
	ATTACKMODE STORAGE
	DISPLAY_TEXT 0 70 Storage Mounted
	WAIT_FOR_BUTTON_PRESS
	RESET
ELSE
	REM Do nothing
	LED_R

Your debug logs

  • I confirm I have read the FAQ: yes
  • I confirm I am using the latest release: yes

Additional information

While 100,100,100 is correct for HSV -> Green, it appears extremely yellow on the device as pictured:
(Not the greatest picture, looks more yellow in person)
Image

Changing to a value like LED 120 100 100 25 works much nicer, and results in a clearer green like this:

Image

Just letting you know that it appears that way, and that green does not really result in green so much as yellow.

@LaikaSpaceDawg LaikaSpaceDawg added the bug Something isn't working label Feb 17, 2025
@i-am-shodan
Copy link
Owner

There is already colour correction for some models in src/Devices/LED/FastLED/HardwareLED.cpp. I'd be happy to accept a similar PR for the apa102 driver here src/Devices/LED/APA102/HardwareLED.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants