Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong number of arguments (given 5, expected 4) #105

Open
amalkumars opened this issue Jul 26, 2021 · 3 comments
Open

wrong number of arguments (given 5, expected 4) #105

amalkumars opened this issue Jul 26, 2021 · 3 comments

Comments

@amalkumars
Copy link

amalkumars commented Jul 26, 2021

I am getting an Argument Error when using trying to publish a message. I am using propono 3.0, ruby-3 and rails-6

[GEM_ROOT]/gems/propono-3.0.0/lib/propono/services/publisher.rb:14:in initialize' initialize: wrong number of arguments (given 5, expected 4) (ArgumentError)
[GEM_ROOT]/gems/propono-3.0.0/lib/propono/services/publisher.rb:9:in new'
[GEM_ROOT]/gems/propono-3.0.0/lib/propono/services/publisher.rb:9:in publish'
[GEM_ROOT]/gems/propono-3.0.0/lib/propono/components/client.rb:54:in publish'

Are we having the support of Ruby3?

@iHiD
Copy link
Owner

iHiD commented Jul 26, 2021

Yeah - so I think Ruby 3 needs **kwargs wherever it uses *args. I don't have time to look at this until Exercism has launched (http://countdown.exercism.io/) but will after that. I'll happily accept a PR too. You can turn on Ruby 3 in CI here: https://github.com/iHiD/propono/blob/main/.github/workflows/tests.yml#L18

@BiggerNoise
Copy link
Contributor

Hello

This one is giving us grief, so I'm working on a P/R for you.

I am running into one issue: Ruby 2.7 seems to be happy with the double splat changes in 3.0, but 2.6 seems to be choking on them. (https://github.com/KoanHealth/propono/actions)

Unfortunately, I have an M1 mac and rbenv won't install anything earlier than 2.7, so I'm having trouble looking more closely at this.

If 2.6 support is key for y'all, then I'll see if I can rope a coworker into helping me out. O/w I can drop 2.6 from the matrix.

Please let me know which you would prefer.

@iHiD
Copy link
Owner

iHiD commented Jan 20, 2022

@BiggerNoise Thanks!
@dougal Tagging you here too as I'm not using Propono in production anywhere atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants