Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use package-lock.json of the repo #31

Open
atxr opened this issue Nov 11, 2022 · 1 comment
Open

Use package-lock.json of the repo #31

atxr opened this issue Nov 11, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers Priority: Low The Issue will be address only if other tasks are done Severity: Trivial The bug or Issue doesn't impact the user, is about esthetics or making things clean

Comments

@atxr
Copy link
Contributor

atxr commented Nov 11, 2022

Currently, when building the website (both prod and dev mode), we are using npm install and regenerating a new package-lock.json.
There is no point of pushing the package-lock.json on the repo if we override them when building.
We should change all the occurrences of npm install by npm ci (clean install) which use the current package-lock.json instead of overriding it.
Hence, we can lock a version of a package we use if needed, and we won't have any version issue when building the app at different places.

@atxr atxr added bug Something isn't working Priority: Low The Issue will be address only if other tasks are done Severity: Trivial The bug or Issue doesn't impact the user, is about esthetics or making things clean labels Nov 11, 2022
@ctmbl
Copy link
Contributor

ctmbl commented Nov 12, 2022

That's right! I'll add this one to the v0.2.0 milestone!

@ctmbl ctmbl added this to the iScsc blog v0.2.0 milestone Nov 12, 2022
@ctmbl ctmbl moved this to Backlog in iScsc website Nov 12, 2022
@ctmbl ctmbl moved this from Backlog to Todo in iScsc website Nov 12, 2022
@ctmbl ctmbl removed this from iScsc website Nov 12, 2022
@ctmbl ctmbl added the good first issue Good for newcomers label Nov 14, 2022
@ctmbl ctmbl moved this to Backlog in iScsc website Nov 18, 2022
@ctmbl ctmbl removed this from the iScsc blog v0.2.0 milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Priority: Low The Issue will be address only if other tasks are done Severity: Trivial The bug or Issue doesn't impact the user, is about esthetics or making things clean
Projects
Status: Backlog
Development

No branches or pull requests

2 participants